Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import of Route 53 records with underscores in the name #14717

Closed
wants to merge 1 commit into from
Closed

Allow import of Route 53 records with underscores in the name #14717

wants to merge 1 commit into from

Conversation

brycekahle
Copy link
Contributor

Fixes #12637, fixes #14465
Supersedes #14466

@akumria
Copy link

akumria commented Jun 1, 2017

Personally I would not have done the extra checking to ensure the R53 supported resource records (as, if it changes, it requires a new terraform build).

But lgtm.

@brycekahle
Copy link
Contributor Author

@akumria That is the only way to know if the last part is a set name, which requires popping off another section to get the record type.

@handlerbot
Copy link
Contributor

handlerbot commented Jun 28, 2017

@brycekahle Thank you for coding this up! I'm getting tripped up on this on the regular right now. 😱

I fear this may have stalled out due to the Terraform/provider split that happened very recently, do you have the time to port your change over to the new GitHub org & repo for the AWS provider, and re-issue this PR there, in the new home of the code? https://github.com/terraform-providers/terraform-provider-aws

@handlerbot
Copy link
Contributor

(If not, I'm glad to try and shuffle this along to success in any way you find acceptable, just let me know!)

@stack72
Copy link
Contributor

stack72 commented Jun 28, 2017

Hi @brycekahle / @handlerbot

I am taking care of this PR right now

Thanks

Paul

@cazorla19
Copy link

Well, is it closed? Can you provide a link to the issue in terraform-provider-aws?
I still don't see a PR there although this bugfix is definitely important.

@handlerbot
Copy link
Contributor

@cazorla19 hashicorp/terraform-provider-aws@2556b00

Can confirm this works, I used it shortly after it was committed.

@brycekahle brycekahle deleted the fix/route53-dns-underscore branch September 19, 2018 19:09
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants